[RFC PATCH, binutils, ARM 5/9] Allow veneers to claim veneered symbols

Nick Clifton nickc@redhat.com
Tue Apr 5 10:06:00 GMT 2016


Hi Thomas,

>> I don't like that "max_stub_type" is not actually the maximum possible
>> value for an elf32_arn_stub_type enum.  The name is misleading.  Maybe
>> you could use something like "last_non_veneer_stub".
> 
> Last is confusing because it's last + 1. To be fair, I don't think this should
> be a stub type, rather a const global variable. I can include that in the
> Cortex-A8 refactoring patch, what do you think?

I think that would be much cleaner, so yes please.

Cheers
  Nick



More information about the Binutils mailing list