[committed, PATCH] Properly convert objects between different ELF classes

Andrew Stubbs ams@codesourcery.com
Fri Sep 25 13:12:00 GMT 2015


On 25/09/15 13:56, H.J. Lu wrote:
> +# Section copies should copy more data than there is in the input
>                             ^^^^^^^^^ What do you mean by "should"?
> +# (i.e. read past end of buffer)
> +# We can't test this directly without valgrind, but --reverse-bytes
> +# ought to use the same value.

There's a missing "not". I'll fix that and the changelog before I commit.

> 2,  You added a new testcase.  But you didn't check if the output
> from objcopy is correct.

It checks that the error message occurs. There shouldn't be any output.

Andrew



More information about the Binutils mailing list