[PATCH ARC 3/8] GAS: new ARC port

Nick Clifton nickc@redhat.com
Fri Sep 4 14:56:00 GMT 2015


Hi Claudiu,

   With a new port like this, please could you add an entry to the 
gas/NEWS file mentioning the addition.



> +  unsigned char short_insn; /* Boolean value: 1 if current insn is short.  */
> +  unsigned char has_limm;   /* Boolean value: 1 if limm field is valid.  */

Please use the bfd_boolean type for boolean values.


> +      { "arc600", ARC_OPCODE_ARC600,  bfd_mach_arc_arc600, E_ARC_MACH_ARC600,  0x00}, /* FIXME! update bfd-in2.h */

Try to keep lines to 80 characters max.


Cheers
   Nick



More information about the Binutils mailing list