[gold][PATCH] PR gold/19119: Gold accepts bogus target emulation

H.J. Lu hjl.tools@gmail.com
Tue Oct 20 17:51:00 GMT 2015


On Fri, Oct 16, 2015 at 8:01 AM, Cary Coutant <ccoutant@gmail.com> wrote:
>>>>         PR gold/19119
>>>>         * options.h (General_options): Remove "obsolete" from -m.
>>>
>>> I'm a little reluctant to remove "obsolete" from the description --
>>> maybe "deprecated" instead?
>> ...
>> It shows that -m elf32ppc is required.  Saying it is obsolete or deprecated
>> isn't correct.
>
> The option is only needed for the very limited case where the inputs
> are empty and we produce an empty object file. In the LTO case, it
> could also be solved by adding a plugin interface so that the plugin
> could tell the linker what the target is (which, again, is only needed
> when building a shared library with no startup files in the link). In
> the kernel case, I don't see a good alternative, but I don't really
> understand why the linker even needs to run when the only input is an
> empty archive. (Maybe we could instead produce a completely empty
> output file for a -r link with no inputs, which would be interpreted
> as an empty script when used in a final link.)
>
> Anyway, I'll hold my "deprecated" argument for another day when these
> two cases can be handled better.
>
>> Is my original patch OK?
>
> Sure.
>

My patch exposed typos in testsuite/Makefile.am.  I checked
in this patch to fix them.


-- 
H.J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Feed-right-input-object-to-x86_64_mov_to_lea1-12.patch
Type: text/x-patch
Size: 3301 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20151020/75b7496e/attachment.bin>


More information about the Binutils mailing list