[patch] Fix BZ 19147 -- readelf -n does not print all file mappings in NT_FILE note (off by one)

H.J. Lu hjl.tools@gmail.com
Sun Oct 18 13:08:00 GMT 2015


On Sat, Oct 17, 2015 at 11:14 PM, Paul Pluzhnikov
<ppluzhnikov@google.com> wrote:
> Greetings,
>
> The following trivial patch fixes BZ 19147. Ok to commit?
>
> Thanks,
>
> 2015-10-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
>
>         PR binutils/19147
>         * binutils/readelf.c (print_core_note): Fix off-by-one bug.
>
>
>
>
> diff --git a/binutils/readelf.c b/binutils/readelf.c
> index e8c215d..22cec2c 100644
> --- a/binutils/readelf.c
> +++ b/binutils/readelf.c
> @@ -15151,7 +15151,7 @@ print_core_note (Elf_Internal_Note *pnote)
>           (int) (4 + 2 * addr_size), _("End"),
>           (int) (4 + 2 * addr_size), _("Page Offset"));
>    filenames = descdata + count * 3 * addr_size;
> -  while (--count > 0)
> +  while (count-- > 0)
>      {
>        bfd_vma start, end, file_ofs;
>
>
> --
> Paul Pluzhnikov

I think this counts as an obvious fix.

Thanks.

-- 
H.J.



More information about the Binutils mailing list