[PATCH] [GAS] sparc: support %dN and %qN syntax for FP registers.

Nick Clifton nickc@redhat.com
Fri Nov 20 15:45:00 GMT 2015


Hi Jose,

> 2015-11-18  Jose E. Marchesi  <jose.marchesi@oracle.com>
>
> 	* config/tc-sparc.c (sparc_ip): Support %dN and %qN notation for
> 	double and quad-precision floating-point registers.

Approved - please apply - but ...


> +                    if (format == 'd' && (mask & 1))
> +                      {
> +                        break;
> +                      };	/* register must be even numbered */
> +
> +                    if (format == 'q' && (mask & 3))
> +                      {
> +                        break;
> +                      }		/* register must be even numbered */
> +
>   		    if ((*args == 'v'
>   			 || *args == 'B'
>   			 || *args == '5'
>

These two tests could be merged into the tests that follow.

Also it would be nice to fix the comments to follow the coding 
guidelines.  Ie:

       {
         /* The register must be even numbered.  */
	break;
       }

Cheers
   Nick



More information about the Binutils mailing list