[AArch64][binutils] Add support for ARMv8.1 Virtulization Host Extensions

Matthew Wahab matthew.wahab@foss.arm.com
Mon Nov 16 14:58:00 GMT 2015


On 15/11/15 12:23, Jan Beulich wrote:
>>>> Matthew Wahab <matthew.wahab@foss.arm.com> 11/09/15 1:50 PM >>>
>> +    rw_sys_reg spsr_el2 x7
>> +    rw_sys_reg elr_el2 x7
>
> Did you mean _el12 in both cases?

Yes, I've changed the test to check the spsr_el12 and elr_el12. The
original test passed because spsr_el2 and elr_el2 are existing system
registers.

> Also did you intentionally leave out tests for the newly added ttbr1_el2,
> contextidr_el2, cnthv_tval_el2, cnthv_ctl_el2, and cnthv_cval_el2?

That was an oversight. I've added them to the test.

> +  /* Virtualization host extensions: *_el12 names of *_el0 registers.  */
>
> Shouldn't this say _el02?

Yes, fixed.
Thanks for looking at the patch.

I've also reworked the patch so that the new registers appear in the
test in the same order as they appear in the opcode table, to make it
easier to keep track of them, and used regexps for the address/offset
part of the expected output.

Tested aarch64-none-linux-gnu with cross-compiled check-binutils and
check-gas.

Ok for trunk?
Matthew

include/opcode/
2015-11-16  Matthew Wahab  <matthew.wahab@arm.com>

	* aarch64.h (AARCH64_FEATURE_V8_1): New.
	(AARCH64_ARCH_v8_1): Add AARCH64_FEATURE_V8_1.

opcodes/
2015-11-16  Matthew Wahab  <matthew.wahab@arm.com>

	* aarch64-opc.c (aarch64_sys_regs): Add spsr_el12, elr_el12,
	sctlr_el12, cpacr_el12, ttbr1_el2, ttbr0_el12, ttbr1_el12,
	tcr_el12, afsr0_el12, afsr1_el12, esr_el12, far_el12, mair_el12,
	amair_el12, vbar_el12, contextidr_el2, contextidr_el12,
	cntkctl_el12, cntp_tval_el02, cntp_ctl_el02, cntp_cval_el02,
	cntv_tval_el02, cntv_ctl_el02, cntv_cval_el02, cnthv_tval_el2,
	cnthv_ctl_el2, cnthv_cval_el2.
	(aarch64_sys_reg_supported_p): Update for the new system
	registers.

gas/testsuite/
2015-11-16  Matthew Wahab  <matthew.wahab@arm.com>

	* virthostext-directive.d: New.
	* virthostext.d: New.
	* virthostext.s: New.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-AArch64-Add-ARMv8.1-Virtualization-Host-Extensions-s.patch
Type: text/x-patch
Size: 17364 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20151116/3124e984/attachment.bin>


More information about the Binutils mailing list