[PATCH dlltool] Clear .idata$6 before use

Nicholas Clifton nickc@redhat.com
Fri May 29 10:07:00 GMT 2015


Hi Stephen,

> The memory allocated for .idata$6 in dlltool isn't cleared before use, which
> can result in random data remaining after the import names. (I noticed this
> when working on making DLLs build reproducibly.)
>
> The following patch just memsets the allocated memory.

Thanks.  You could have also just changed the xmalloc to xcalloc, but 
there is just a minor point.

I have gone ahead and applied your patch along with this changelog entry.

Cheers
   Nick

binutils/ChangeLog
2015-05-29  Stephen Kitt  <steve@sk2.org>

	* dlltool.c (make_one_lib_file): Clear .idata$6 before use.




More information about the Binutils mailing list