Compact EH binutils patch

Moore, Catherine Catherine_Moore@mentor.com
Fri May 22 19:50:00 GMT 2015


This comment did not make it to the list, so I'm copying it now.

Hi Nick,
Thank you for reviewing this patch.
I've now fixed these regressions and the patch has been rebased.  I'm attaching the updated patch for review.
Will you please let me know if it's okay to commit?
Thanks,
Catherine

-----Original Message-----
From: Nicholas Clifton [mailto:nickc@redhat.com] 
Sent: Monday, May 11, 2015 12:29 PM

Hi Catherine,

Sorry for the delay in getting back to you.  I have been going through the patch, trying to understand what it is doing.  It looks basically sound to me, but there is one problem - it introduces some regressions in my binutils testsuite checker.  Specifically:

Checking Binutils in: alpha-linux-gnu ... GAS: 3 LD: 3 done
   GAS REGRESSION: alpha elf-reloc-8
   GAS REGRESSION: CFI on alpha
   GAS REGRESSION: CFI on alpha, 2
   LD REGRESSION: TLS -fpic -shared
   LD REGRESSION: TLS -fpic and -fno-pic exec
   LD REGRESSION: TLS -fpic and -fno-pic exec

Checking Binutils in: alpha-unknown-freebsd4.7 ... GAS: 1 done
  GAS REGRESSION: alpha elf-reloc-8

Checking Binutils in: mips-sgi-irix6 ... GAS: 78 LD: 51 BIN: 2 done
   GAS REGRESSION: Compact EH EB #1 with
   GAS REGRESSION: Compact EH EB #2 with
   GAS REGRESSION: Compact EH EB #3 with
   GAS REGRESSION: Compact EH EB #4 with
   GAS REGRESSION: Compact EH EB #5 with
   GAS REGRESSION: Compact EH EB #6 with
   GAS REGRESSION: Compact EH EB #7 with
   GAS REGRESSION: Compact EH EL #1 with
   GAS REGRESSION: Compact EH EL #2 with
   GAS REGRESSION: Compact EH EL #3 with
   GAS REGRESSION: Compact EH EL #4 with
   GAS REGRESSION: Compact EH EL #5 with
   GAS REGRESSION: Compact EH EL #6 with
   GAS REGRESSION: Compact EH EL #7 with

Could you have a look at these and see what is causing them/how to fix them ?  I can provide you with the log files if it will help.

Cheers
   Nick

-------------- next part --------------
A non-text attachment was scrubbed...
Name: compact-eh-2015-05-22.cl
Type: application/octet-stream
Size: 7023 bytes
Desc: compact-eh-2015-05-22.cl
URL: <https://sourceware.org/pipermail/binutils/attachments/20150522/337f195f/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: compact-eh-2015-02-08.patch
Type: application/octet-stream
Size: 124430 bytes
Desc: compact-eh-2015-02-08.patch
URL: <https://sourceware.org/pipermail/binutils/attachments/20150522/337f195f/attachment-0001.obj>


More information about the Binutils mailing list