[AArch64] Remove BFD overflow check restrictions

Jiong Wang jiong.wang@arm.com
Tue May 12 14:43:00 GMT 2015


I have been adding some testcases to test relocation overflow, while bfd
linker haven't given any error report.

After some debugging, it's caused by these extra checked removed in the
patch. They prevent the error report happening.

Although the comment says:

 "If the overflowing reloc was to an undefined symbol, we have already
 printed one error message and there is no point complaining again."

But, I haven't seen any error message before reach here.

x86/mips/sparc etc don't have such restriction. "git blame" shows it
first added to ARM back in 2000, 15 years ago, then propagated to a few
other targets including AArch64.

These code do looks insane and hard to understand, this patch remove
them. I'd like to fix further issue caused by this remove if any.

OK for trunk and 2.25 backport?

Thanks.

2015-05-12  Jiong Wang  <jiong.wang@arm.com>

bfd/
  * elfnn-aarch64.c (elfNN_aarch64_relocate_section): Remove overflow check restrictions.
-- 
Regards,
Jiong

-------------- next part --------------
A non-text attachment was scrubbed...
Name: remove-check.patch
Type: text/x-diff
Size: 1010 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20150512/b16f79dc/attachment.bin>


More information about the Binutils mailing list