[PATCH] PR ld/18169: sh_info of .rel.plt/.rela.plt sections isn't correct

[H.J. Lu]

On Thu, Mar 26, 2015 at 4:55 PM, Alan Modra <amodra@gmail.com> wrote:
> On Thu, Mar 26, 2015 at 11:34:55AM -0700, H.J. Lu wrote:
>> Since .rela.plt/rel.plt section doesn't contain relocations against .plt
>> section, we shouldn't set sh_info for .rela.plt/rel.plt section.
>
> That depends entirely on your ABI.  I'd argue that on x86 you ought to
> be setting sh_info for .rel.plt to the .got.plt section index.
> Setting sh_info to zero is not correct.
>

Here is a patch.  I used want_got_plt to check if .rel.plt applies to
.got.plt.  If it doesn't work for a target, target can provide its own
elf_backend_get_reloc_section.  OK for master?

Thanks.


-- 
H.J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Properly-set-sh_info-for-.rela.plt-rel.plt-section.patch
Type: text/x-patch
Size: 5931 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20150327/49ef2160/attachment.bin>