[PATCH][AARCH64]Fix bintest.s failure after "Fix align directive causes MAP_DATA symbol to be lost" change

Renlin Li renlin.li@arm.com
Thu Mar 26 17:31:00 GMT 2015


Hi,

This patch adjusts bintest.s test case according to the MAP_DATA symbols 
change made recently. 
https://sourceware.org/ml/binutils/2015-03/msg00331.html

After the change, we emit MAP_DATA symbols even there is no instruction 
in .text section.
So we have got one more data symbol for bintest.s test case.

The fix is similar to the method used for arm. The desired output is adjust.

Binutils regression test runs Okay. Okay to commit?

Regards,
Renlin Li

binutils/testsuite/ChangeLog:

2015-03-26  Renlin Li  <renlin.li@arm.com>

     * binutils-all/readelf.s-64: Support aarch64 case.
     * binutils-all/readelf.ss-64: Likewise.


On 26/03/15 11:03, Renlin Li wrote:
> Hi Marcus,
>
> After the change, we emit MAP_DATA symbols even there is no instruction
> in .text section.
> So we have got one more data symbol for bintest.s test case.
>
> I will double check and find a solution.
>
> Regards,
> Renlin
>
> On 26/03/15 09:29, Marcus Shawcroft wrote:
>>
>> On 25 March 2015 at 12:26, Nicholas Clifton <nickc@redhat.com
>> <mailto:nickc@redhat.com>> wrote:
>>
>>      Hi Renlin,
>>
>>          gas/ChangeLog:
>>
>>          2015-03-24  Renlin Li  <renlin.li@arm.com
>>          <mailto:renlin.li@arm.com>>
>>
>>               * config/tc-aarch64.c (mapping_state): Remove first MAP_DATA
>>          emitting code.
>>               (mapping_state_2): Emit first MAP_DATA symbol here.
>>
>>
>>      Approved - please apply.
>>
>>      Cheers
>>        Nick
>>
>>
>> This patch appears to causes the following two regressions for
>> aarch64-none-linux-gnu:
>> FAIL: readelf -S
>> FAIL: readelf -s
>>
>> Cheers
>> /Marcus
>


-------------- next part --------------
A non-text attachment was scrubbed...
Name: tmp.diff
Type: text/x-patch
Size: 1723 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20150326/c861a323/attachment.bin>


More information about the Binutils mailing list