[PATCH] ld/emulparams/elf32_tic6x_le.sh: Skip OTHER_BSS_SECTIONS for "-r" option.
Alan Modra
amodra@gmail.com
Tue Mar 24 03:24:00 GMT 2015
On Tue, Mar 24, 2015 at 10:59:05AM +0800, Chen Gang wrote:
> On 3/24/15 08:23, Alan Modra wrote:
> > On Sat, Mar 21, 2015 at 11:20:04PM +0800, Chen Gang wrote:
> >> * emulparams/elf32_tic6x_le.sh: Skip OTHER_BSS_SECTIONS for "-r"
> >> option.
> >
> > This looks OK, except
> >
> >> +# For ld -r, skip OTHER_BSS_SECTIONS, or will cause multiple definition.
> >> +OTHER_BSS_SECTIONS="";
> >> +if [ "x${LD_FLAG}" != "xr" ]; then
> >
> > this should test $RELOCATING instead of $LD_FLAG.
> >
>
> OK, thanks. I guess your meaning is that we need use ${RELOCATING-0}
> instead of "x${LD_FLAG}" != "xr". If it is incorrect, please let me
> know (the related diff may like below).
No, that won't work. I meant something like
if test -n "$RELOCATING"; then
--
Alan Modra
Australia Development Lab, IBM
More information about the Binutils
mailing list