[PATCH] Disable all target libraries if not building gcc

H.J. Lu hjl.tools@gmail.com
Wed Mar 18 00:08:00 GMT 2015


On Mon, Mar 16, 2015 at 8:01 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Mon, Mar 16, 2015 at 7:26 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
>> On Mon, Mar 16, 2015 at 4:43 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
>>> On Mon, Mar 16, 2015 at 4:41 PM, Joseph Myers <joseph@codesourcery.com> wrote:
>>>> On Mon, 16 Mar 2015, H.J. Lu wrote:
>>>>
>>>>> On Mon, Mar 16, 2015 at 3:50 PM, Joseph Myers <joseph@codesourcery.com> wrote:
>>>>> > On Fri, 13 Mar 2015, H.J. Lu wrote:
>>>>> >
>>>>> >> I am working on SHF_COMPRESSED support:
>>>>> >>
>>>>> >> http://www.sco.com/developers/gabi/latest/ch4.sheader.html
>>>>> >>
>>>>> >> I will import zlib from GCC source tree into binutils-gdb tree.  But zlib
>>>>> >> failed to build as a target library in binutils-gdb.  There is no need to
>>>>> >> build target libraries if not building gcc.  OK for master?
>>>>> >
>>>>> > This is definitely wrong.  newlib / libgloss is a target library that
>>>>> > certainly makes sense to build separately from GCC, and the toplevel
>>>>> > configure / build code should be identical in all three repositories (GCC,
>>>>> > binutils-gdb, newlib-cygwin).
>>>>>
>>>>> We need to work out something to avoid building target libraries
>>>>> in binutils.
>>>>
>>>> I suggest not building zlib as a target library unless libgcj is also
>>>> being built as a target library, given that there should be no need to
>>>> built it as a target library in isolation.
>>>>
>>>
>>> The logic is there.  But somehow it doesn't work for binutils.
>>> I will take another look.
>>>
>>
>> Here is a patch.  It excludes target-zlib if target-libjava isn't built.
>> Tested in binutils and GCC with java.
>>
>
> This version is more flexible to support future target libraries
> which depend on target zlib.
>

I reverted my previous commit and checked in this one.


-- 
H.J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Exclude-target-zlib-if-target-libjava-isn-t-built.patch
Type: text/x-patch
Size: 2841 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20150318/b7ab1b6c/attachment.bin>


More information about the Binutils mailing list