[PATCH] Fix AVX512 vcvtt?ps2u?qq instructions disassembly (Intel syntax)/18631

H.J. Lu hjl.tools@gmail.com
Mon Jul 20 15:44:00 GMT 2015


On Mon, Jul 20, 2015 at 8:31 AM, Fomin, Alexander
<alexander.fomin@intel.com> wrote:
> For Intel AVX512 vcvtt?ps2u?qq instructions with broadcasting enabled,
> memory operand size should be DWORD, not QWORD.
> An additional Intel syntax test with memory operand and broadcasting
> enabled has been added to gas testsuite.
>
> Thanks,
> Alexander
> ----
> gas/testsuite
>         * gas/i386avx512dq-intel.d: Replace "QWORD" with "DWORD" in
>         vcvtt?ps2u?qq instructions disassembly regexes.
>         Add disassembly regex for new test.
>         * gas/i386/avx512dq.d: Likewise.
>         * gas/i386/avx512dq_vl-intel.d: Likewise.
>         * gas/i386/avx512dq_vl.d: Likewise.
>         * gas/i386/x86-64-avx512dq-intel.d: Likewise.
>         * gas/i386/x86-64-avx512dq.d: Likewise.
>         * gas/i386/x86-64-avx512dq_vl-intel.d: Likewise.
>         * gas/i386/x86-64-avx512dq_vl.d: Likewise.
>         * gas/i386/avx512dq.s: Add new test for Intel syntax with memory
>         operand and broadcasting enabled.
>         * gas/i386/avx512dq_vl.s: Likewise.
>         * gas/i386/x86-64-avx512dq.s: Likewise.
>         * gas/i386/x86-64-avx512dq_vl.s: Likewise.
>
> opcodes/
>         * i386-dis-evex.h (EVEX_W_0F78_P_2): Replace "EXxmmq" with
>         "EXEvexHalfBcstXmmq" for second operand.
                                                  ^^^ "the" second operand.

>         (EVEX_W_0F79_P_2): Likewise
                                                         ^^^ Missing ".".
>         (EVEX_W_0F7A_P_2): Likewise

See above.

>         (EVEX_W_0F7B_P_2): Likewise

See above.

> ---
>  gas/testsuite/gas/i386/avx512dq-intel.d           |  84 +++++------
>  gas/testsuite/gas/i386/avx512dq.d                 |   4 +
>  gas/testsuite/gas/i386/avx512dq.s                 |   4 +
>  gas/testsuite/gas/i386/avx512dq_vl-intel.d        | 168 +++++++++++-----------
>  gas/testsuite/gas/i386/avx512dq_vl.d              |   8 ++
>  gas/testsuite/gas/i386/avx512dq_vl.s              |   8 ++
>  gas/testsuite/gas/i386/x86-64-avx512dq-intel.d    |  84 +++++------
>  gas/testsuite/gas/i386/x86-64-avx512dq.d          |   4 +
>  gas/testsuite/gas/i386/x86-64-avx512dq.s          |   4 +
>  gas/testsuite/gas/i386/x86-64-avx512dq_vl-intel.d | 168 +++++++++++-----------
>  gas/testsuite/gas/i386/x86-64-avx512dq_vl.d       |   8 ++
>  gas/testsuite/gas/i386/x86-64-avx512dq_vl.s       |   8 ++
>  opcodes/i386-dis-evex.h                           |   8 +-
>  13 files changed, 316 insertions(+), 244 deletions(-)
>

OK with those changes.

Thanks.

-- 
H.J.



More information about the Binutils mailing list