Allow pie links to create PLT entries

[H.J. Lu]

On Thu, Jan 29, 2015 at 11:00 AM, Sriraman Tallam <tmsriram@google.com> wrote:
> Hi,
>
>     Here is a simple example that fails to link with -pie but which
> should work just fine without having to use -fPIE.
>
> foo.cc
> ======
> int extern_func();
> int main()
> {
>   extern_func();
>   return 0;
> }
>
> bar.cc
> =====
> int extern_func()
> {
>   return 1;
> }
>
> $ g++ -fPIC -shared bar.cc -o libbar.so
> $ g++ foo.cc -lbar -pie
>
> ld: error: foo.o: requires dynamic R_X86_64_PC32 reloc against
> '_Z11extern_funcv' which may overflow at runtime; recompile with -fPIC
>
> It fails because the linker disallows creating a PLT for
> R_X86_64_PC32 reloc when it is perfectly fine to do so.  Note that I
> could have recompiled foo.cc with -fPIE or -fPIC but I still think
> this can be allowed.  With support for copy relocations in pie in gold
> and with this support, the cases where we would need to use -fPIE to
> get working pie links is smaller.  This would help us link non-PIE
> objects into pie executables.

You can't do it for x86 since EBX isn't setup for calling via PLT.
For x86-64, there should be little difference between PIE
and non-PIE code.  What do you gain by building PIE without
-fPIE on x86-64?

>
> Attached patch to fix this. I have only tested this patch on X86_64.
>
> Please review.
>
> Thanks
> Sri



-- 
H.J.