[PATCH][ARM][gas]: vcmp/vcmpe should accept #0x0 as an operand.

Matthew Wahab matthew.wahab@arm.com
Thu Jan 8 10:10:00 GMT 2015


Hello,

gas rejects #0x0 as an operand to vcmp/vcmpe, complaining about garbage 
at the end of the line, while gas-2.24 accepts the operand without 
complaining. The change in behaviour was introduced when 
parse_ifimm_zero was added 
(https://sourceware.org/ml/binutils/2014-08/msg00010.html) and seems to 
have been inadvertent. This patch restores the previous behaviour.

To reproduce:
-- 
test.s:
   vcmp.f32 s0, #0x0
   vcmpe.f32 s1, #0x0
 > arm-none-linux-gnueabihf-as -c -mfpu=vfpv3 test.s

Tested arm-none-linux-gnueabihf which passes make check-gas

Matthew

ChangeLog:
-- 
gas/
2015-01-08  Matthew Wahab  <matthew.wahab@arm.com>

     * config/tc-arm.c (parse_ifimm_zero): Accept #0x0 as a synonym for
     #0, restoring previous behaviour.

gas/testsuite/
2015-01-08  Matthew Wahab  <matthew.wahab@arm.com>

     * gas/arm/ual-vcmp.s: Add vcmp, vcmpe with #0x0 operand.
     * gas/ual/vcmp.d: Update expected output.
     * gas/ual/vcmp-zero-bad.l: Likewise
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gnutoosl5105.patch
Type: text/x-patch
Size: 3147 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20150108/63f02ed9/attachment.bin>


More information about the Binutils mailing list