[PATCH 1/2] objcopy: Factor out some of the option parsing code.

Andrew Burgess andrew.burgess@embecosm.com
Thu Feb 26 06:48:00 GMT 2015


* Richard Sandiford <rdsandiford@googlemail.com> [2015-02-25 21:07:41 +0000]:

> Andrew Burgess <andrew.burgess@embecosm.com> writes:
> > diff --git a/binutils/objcopy.c b/binutils/objcopy.c
> > index 8320793..eb26320 100644
> > --- a/binutils/objcopy.c
> > +++ b/binutils/objcopy.c
> > @@ -3546,6 +3546,79 @@ convert_efi_target (char *efi)
> >      }
> >  }
> >
> > +/* Allocate and return a pointer to a struct section_add, initialising the
>
> Nit: "initializing".  (binutils uses US spelling.)
>
> OK with that change, thanks.  I think this should go in independently
> of patch 2, since it's a clean-up in its own right.

Thanks for the review, I pushed with the suggested fix.

Andrew



More information about the Binutils mailing list