[PATCH] gold: Implement --long-plt flag.

Peter Collingbourne pcc@google.com
Thu Dec 17 20:33:00 GMT 2015


On Wed, Dec 16, 2015 at 4:42 PM, Cary Coutant <ccoutant@gmail.com> wrote:
>
> >  template<bool big_endian>
> >  void
> > -Output_data_plt_arm_standard<big_endian>::do_fill_plt_entry(
> > +Output_data_plt_arm_short<big_endian>::do_fill_plt_entry(
> >      unsigned char* pov,
> >      Arm_address got_address,
> >      Arm_address plt_address,
>
> Please fix this routine to issue an error message, suggesting the use
> of --long-plt, if the offset overflows the standard PLT.
>
> > +  DEFINE_bool(long_plt, options::TWO_DASHES, '\0', false,
> > +             N_("(ARM only) Generate long PLT entries."),
> > +             N_("(ARM only) Do not generate long PLT entries."));
>
> Help strings should not end with periods. (Yeah, there are some already there.)
>
> This is OK with those changes.

Thanks, new patch is attached. Can you please commit for me?

Peter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-gold-Implement-long-plt-flag.patch
Type: text/x-patch
Size: 8196 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20151217/833eca7a/attachment.bin>


More information about the Binutils mailing list