[GAS][ARM]Positively emit symbols for alignment. --> [PATCH][LD][ARM] Fix two test case failures.

[Richard Earnshaw]

On 29/04/15 10:21, Renlin Li wrote:
> Hi Hans-Peter,
> 
> Thank you for your report! I have attached the patch to fix the test cases.
> 
> Previously, the padding bytes are treated as instruction, because data 
> mapping symbols are missing. With the new patch, data mapping symbols 
> are emitted, the bytes thereafter are correctly interpreted as data.
> 
> Okay to commit?
> 

OK.

R.

> Regards,
> Renlin Li
> 
> ld/testsuite/ChangeLog:
> 
> 2015-04-29  Renlin Li  <renlin.li@arm.com>
> 
>      * ld-arm/ifunc-10.dd: Adjust expected output.
>      * ld-arm/ifunc-2.dd: Likewise.
> 
> On 28/04/15 22:07, Hans-Peter Nilsson wrote:
>> Maybe you refer to some other target (which one?) than
>> arm-unknown-eabi, because for arm-unknown-eabi, this patch
>> caused failures in the ld testsuite:
>>
>> Running /tmp/hpautotest-binutils/bsrc/src/ld/testsuite/ld-arm/arm-elf.exp ...
>> FAIL: IFUNC test 2
>> FAIL: IFUNC test 10
>>
>> I'm guessing you just need to adjust the
>> expected-result-templates for the "mapping symbols".
>>
>> brgds, H-P
>>
>>
>> ld.diff
>>
>>
>> diff --git a/ld/testsuite/ld-arm/ifunc-10.dd b/ld/testsuite/ld-arm/ifunc-10.dd
>> index 88bae50..d96c086 100644
>> --- a/ld/testsuite/ld-arm/ifunc-10.dd
>> +++ b/ld/testsuite/ld-arm/ifunc-10.dd
>> @@ -267,7 +267,7 @@ Disassembly of section \.text:
>>  
>>  0000a010 <tbf1>:
>>      a010:	46f7      	mov	pc, lr
>> -    a012:	0000      	movs	r0, r0
>> +    a012:	0000      	.short	0x0000
>>      a014:	e1a0f00e 	mov	pc, lr
>>      a018:	e1a0f00e 	mov	pc, lr
>>      a01c:	e1a0f00e 	mov	pc, lr
>> diff --git a/ld/testsuite/ld-arm/ifunc-2.dd b/ld/testsuite/ld-arm/ifunc-2.dd
>> index f6d57fa..91eab54 100644
>> --- a/ld/testsuite/ld-arm/ifunc-2.dd
>> +++ b/ld/testsuite/ld-arm/ifunc-2.dd
>> @@ -84,10 +84,10 @@ Disassembly of section \.text:
>>  
>>  0000a00c <f4>:
>>      a00c:	46f7      	mov	pc, lr
>> -    a00e:	0000      	movs	r0, r0
>> +    a00e:	0000      	.short	0x0000
>>      a010:	e1a0f00e 	mov	pc, lr
>>      a014:	46f7      	mov	pc, lr
>> -    a016:	0000      	movs	r0, r0
>> +    a016:	0000      	.short	0x0000
>>      a018:	e1a0f00e 	mov	pc, lr
>>      a01c:	46f7      	mov	pc, lr
>>  	\.\.\.