PATCH: Update --with-system-zlib

Bernhard Reutner-Fischer rep.dot.nop@gmail.com
Wed Apr 1 17:05:00 GMT 2015


On April 1, 2015 6:54:31 PM GMT+02:00, Mike Frysinger <vapier@gentoo.org> wrote:
>On 01 Apr 2015 05:04, H.J. Lu wrote:
>> --- a/config/zlib.m4
>> +++ b/config/zlib.m4
>> @@ -9,8 +9,10 @@ AC_DEFUN([AM_ZLIB],
>>    zlibinc="-I\$(srcdir)/../zlib"
>>    AC_ARG_WITH(system-zlib,
>>    [AS_HELP_STRING([--with-system-zlib], [use installed libz])],
>> -  zlibdir=
>> -  zlibinc=
>> +  if test x$with_system_zlib = xyes ; then
>> +    zlibdir=
>> +    zlibinc=
>> +  fi
>>    )
>
>this is inside the 3rd arg, so normally you check $withval.  this code
>will 
>still work as the generated shell does:
>if test "${with_system_zlib+set}" = set; then :

Why doesn't this expand to test -n "${with_system_zlib+set}"
nowadays, BTW? Would be faster to parse and supposedly sums up quite a bit, fwiw.

Cheers,

>  withval=$with_system_zlib; [3rd arg content]
>fi
>
>>  bfd/ChangeLog      | 4 ++++
>>  bfd/configure      | 6 ++++--
>>  binutils/ChangeLog | 4 ++++
>>  binutils/configure | 6 ++++--
>>  gas/ChangeLog      | 4 ++++
>>  gas/configure      | 6 ++++--
>>  gdb/ChangeLog      | 4 ++++
>>  gdb/configure      | 6 ++++--
>
>you need to regenerate the sim tree too
>-mike




More information about the Binutils mailing list