[patch] Fix handling of common symbols with plugins

Cary Coutant ccoutant@google.com
Tue Sep 30 23:01:00 GMT 2014


> Oops, wrong commit.  The patch that causes the failure is the one you
> suspected, 1707f183, your PR 17432 change.

It was a cut-and-paste error on my part, sorry! This should fix it...

-cary


diff --git a/gold/resolve.cc b/gold/resolve.cc
index 52dae8b..07dff4a 100644
--- a/gold/resolve.cc
+++ b/gold/resolve.cc
@@ -317,8 +317,8 @@ Symbol_table::resolve(Sized_symbol<size>* to,
          if (to->is_common() && !is_ordinary && st_shndx == elfcpp::SHN_COMMON)
            {
              adjust_common = true;
-             typename Sized_symbol<size>::Size_type tosize = to->symsize();
-             typename Sized_symbol<size>::Value_type tovalue = to->value();
+             tosize = to->symsize();
+             tovalue = to->value();
            }
          this->override(to, sym, st_shndx, is_ordinary, object, version);
          if (adjust_common)



More information about the Binutils mailing list