[PATCH] Don't sign extend the addend for R_MIPS_PC16 and R_MIPS_GNU_REL16_S2 if relocations are RELA

Maciej W. Rozycki macro@codesourcery.com
Mon Sep 29 13:58:00 GMT 2014


On Sun, 21 Sep 2014, Richard Sandiford wrote:

> Andrew Bennett <Andrew.Bennett@imgtec.com> writes:
> > bfd/
> > 	* elfxx-mips.c (mips_elf_calculate_relocation): Don't sign extend
> > 	the addend if relocations are RELA.
> 
> OK, thanks, and sorry for the slow review.

 Any chance for test cases to cover the bug?  From the nature of the 
problem it looks to me they should be straightforward to make.

  Maciej



More information about the Binutils mailing list