[patch] Fix handling of common symbols with plugins

Rafael Espíndola rafael.espindola@gmail.com
Thu Sep 18 16:54:00 GMT 2014


Sorry, now with the correct patch.

On 18 September 2014 12:53, Rafael Espíndola <rafael.espindola@gmail.com> wrote:
>> +# plugin_test_6.sh -- a test case for the plugin API.
>> +
>> +# Copyright (C) 2010-2014 Free Software Foundation, Inc.
>> +# Written by Cary Coutant <ccoutant@google.com>.
>>
>> Update these lines.
>
> Done.
>
>> +readelf -SW plugin_test_10 > plugin_test_10.sections
>> +grep ".bss.* 8$" plugin_test_10.sections > /dev/null
>> +
>> +exit 0
>>
>> The readelf command should be run from the Makefile itself. Create a
>> new rule for plugin_test_10.sections, and use $(TEST_READELF). There
>> are several examples of this in testsuite/Makefile.am.
>>
>> Then your test script only needs to run grep, but use grep's "-q"
>> option instead of "> /dev/null".
>
> Done.
>
> New patch attached.
>
> Cheers,
> Rafael
>
> 2014-09-18  Rafael Ávila de Espíndola <rafael.espindola@gmail.com>
>
>         * testsuite/Makefile.am (plugin_test_10): New test.
>         * testsuite/Makefile.in: Regenerate
>         * testsuite/plugin_common_test_2.c (c1): Align to 8.
>         * testsuite/plugin_test_10.sh: New file.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: t.patch
Type: text/x-patch
Size: 11904 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20140918/eaf26a39/attachment.bin>


More information about the Binutils mailing list