[PATCH, ARM] Add support for value 3 of Tag_ABI_VFP_args attribute
Thomas Preud'homme
thomas.preudhomme@arm.com
Wed Oct 29 16:05:00 GMT 2014
> From: Nicholas Clifton [mailto:nickc@redhat.com]
> Sent: Wednesday, October 29, 2014 4:02 PM
>
> The patch itself is basically fine, although I do have one request for a
> change (see below). I should mention however that we can only
> approve
> the changes to the binutils sources. For the change to the GDB sources
> you will have to submit a separate email to the
> gdb-patches@sourceware.org mailing list.
Ah thanks for telling me. I didn't know that.
>
> The one change I would like to see is to replace the use of numeric
> values 0, 1, 2, and 3 for the Tag_ABI_VFP tag with words instead. Ie
> please create an enum for the values and then use the enum values in
> the
> patch. This makes the code easier to read in my opinion.
Yep, it makes sense. I'll make a new revision of that patch.
Best regards,
Thomas
More information about the Binutils
mailing list