RFC: using AdaCore's git hooks for binutils-gdb.git ...

Joseph Myers joseph@codesourcery.com
Fri Nov 28 18:06:00 GMT 2014


On Fri, 28 Nov 2014, H.J. Lu wrote:

> Do we need to show the whole diff in the commit email?  I think
> a commit URL should be sufficient.  Binutils-gdb commit
> can have a very large commit diff due to generated files.

For glibc we show the diff in the email to glibc-cvs, but *not* in the 
Bugzilla update (I'm not sure if the Bugzilla update works via sending 
emails to each bug whose number was extracted from the commit message, or 
by some other interface - but in any case, different messages are used for 
the two cases).  Obviously you'd want to make sure that the patterns used 
to extract bug numbers are compatible with all those commonly used for 
binutils and GDB at present.

In the early days of glibc git, sending the diff did result in at least 
one 500MB email to glibc-cvs when the hook decided some branch commit 
required the whole history (or at least the whole source tree) to be 
emailed out, but I haven't seen such problems lately.

I don't know if binutils-gdb uses the whitespace checks that glibc does 
(but again, you'd probably want to be compatible with the existing logic).

-- 
Joseph S. Myers
joseph@codesourcery.com



More information about the Binutils mailing list