[PATCH] gas/config/tc-tic4x.c: Let insn name full use its space and always zero terminated
Mon Nov 24 03:28:00 GMT 2014
On Mon, Nov 17, 2014 at 11:47:08PM +0800, Chen Gang wrote:
> strncpy() can not be sure of insn name must be zero terminated, so need
> set it explicitly.
> At present, insn name is only used in tic4x_insn_check() which only test
> insn name within 9 chars explicitly. So it is harmless to use full space
> of insn name for strncpy().
Not OK. You missed noticing that md_assemble is called recursively
for parallel instructions, and does strcat (insn->name, "_"). So
space must be reserved.
Australia Development Lab, IBM
More information about the Binutils