[PATCH] Pretty-printing plt entries on ARM

Pavel Fedin p.fedin@samsung.com
Fri Mar 7 05:13:00 GMT 2014


 Hello!

> >  2. In your implementation nobody will deallocate both context and
> > cached data.
> 
> True, should be addressed with new patch.

 IMHO still too much overcomplicated. In this function i always goes from 0
to count - 1, so there's no practical point in creating the array and then
deallocating it.
Well, if you really want to get rid of dependence on the order of 'i'
between calls, then i would move context deallocation to the end of
_bfd_elf_get_synthetic_symtab(). Something like "if (ctx) free (ctx)".

Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia




More information about the Binutils mailing list