[PATCH] or1k: fix warnings about unsigned constants

[Pierre Muller]

This has been discussed already in the thread I started a while ago:
https://sourceware.org/ml/binutils/2014-05/msg00152.html

and
https://sourceware.org/ml/binutils/2014-05/msg00195.html

A fix was then proposed to cgen mailing list in:

https://sourceware.org/ml/cgen/2014-q2/msg00005.html

But apparently, nothing has been decided on that end yet.


Pierre Muller

> -----Message d'origine-----
> De : binutils-owner@sourceware.org [mailto:binutils-
> owner@sourceware.org] De la part de Nicholas Clifton
> Envoyé : jeudi 26 juin 2014 14:20
> À : Philippe De Muyter; binutils@sourceware.org
> Cc : Stefan Kristiansson
> Objet : Re: [PATCH] or1k: fix warnings about unsigned constants
> 
> Hi Philippe,
> 
> > or1k-desc.h:260:73: error: this decimal constant is unsigned only in
> ISO C90 [-Werror]
> > or1k-desc.h:263:73: error: this decimal constant is unsigned only in
> ISO C90 [-Werror]
> > or1k-desc.h:270:4: error: this decimal constant is unsigned only in
> ISO C90 [-Werror]
> 
> > Fix that by adding 'u' at the end of those constants.
> 
> I have applied your patch, but... or1k-desc.h is a generated file.  The
> correct solution is to fix the source that was used to build this file
> and then regenerate it.  Unfortunately I cannot find where these
> constants come from.  Perhaps somebody will be able to enlighten me.
> 
> Cheers
>    Nick