Mips target in gold - revision 3 - part 2

Alan Modra amodra@gmail.com
Thu Jun 26 02:14:00 GMT 2014


On Mon, Jun 23, 2014 at 12:10:10PM -0700, Cary Coutant wrote:
> I've committed these changes on your behalf.
> 
> I also included a small fix to configure.tgt (thanks to
> admin@heiher.info), which moves the catch-all "mips*-*-*" case below
> the more specific "mips*el*-*-*|mips*le*-*-*" case.
> 
> Gold now support MIPS! Thanks for all the work on this!

mips.o: In function `emit_entry':
/src/binutils-gdb/gold/mips.cc:7162: undefined reference to `gold::Symbol::should_add_dynsym_entry(gold::Symbol_table*) const'
mips.o: In function `emit':
/src/binutils-gdb/gold/mips.cc:3461: undefined reference to `gold::Symbol::should_add_dynsym_entry(gold::Symbol_table*) const'
mips.o: In function `count_got_symbols':
/src/binutils-gdb/gold/mips.cc:5275: undefined reference to `gold::Symbol::should_add_dynsym_entry(gold::Symbol_table*) const'
/src/binutils-gdb/gold/mips.cc:5275: undefined reference to `gold::Symbol::should_add_dynsym_entry(gold::Symbol_table*) const'
/src/binutils-gdb/gold/mips.cc:5275: undefined reference to `gold::Symbol::should_add_dynsym_entry(gold::Symbol_table*) const'
mips.o:/src/binutils-gdb/gold/mips.cc:5977: more undefined references to `gold::Symbol::should_add_dynsym_entry(gold::Symbol_table*) const' follow

OK to apply?

	* symtab.cc (Symbol::should_add_dynsym_entry): Don't make inline.

diff --git a/gold/symtab.cc b/gold/symtab.cc
index 4e8afb1..b329bb6 100644
--- a/gold/symtab.cc
+++ b/gold/symtab.cc
@@ -334,7 +334,7 @@ Sized_symbol<size>::allocate_common(Output_data* od, Value_type value)
 // Return true if this symbol should be added to the dynamic symbol
 // table.
 
-inline bool
+bool
 Symbol::should_add_dynsym_entry(Symbol_table* symtab) const
 {
   // If the symbol is only present on plugin files, the plugin decided we

-- 
Alan Modra
Australia Development Lab, IBM



More information about the Binutils mailing list