[Patch bfd] Remove unneeded comma expression from bfd_set_section_userdata, bfd_set_section_alignment, bfd_set_section_vma

Tom Tromey tromey@redhat.com
Mon Jan 27 17:33:00 GMT 2014


>>>>> "Ramana" == Ramana Radhakrishnan <ramrad01@arm.com> writes:

Ramana> Uggh, it looks like I didn't test when the hunks included
Ramana> bfd_set_section_vma and bfd_set_section_alignment because this expects
Ramana> the TRUE to be meaningful and uses that in conditions in a number of
Ramana> places.

Ramana> The problem though is real and builds appear to be broken with
Ramana> trunk gcc.

I wonder if it would be acceptable to replace it with a static inline
function.  I think that would avoid the warning.  "static inline" is
already unconditionally used in BFD, so I don't think there's a
portability issue.

Tom



More information about the Binutils mailing list