[RFC PATCH] bfd/elf32-arm.c: Set st_value to zero for undefined symbols.

Will Newton will.newton@linaro.org
Mon Jan 27 12:00:00 GMT 2014


On 24 January 2014 10:11, Will Newton <will.newton@linaro.org> wrote:
> On 24 January 2014 04:17, Alan Modra <amodra@gmail.com> wrote:
>> On Thu, Jan 23, 2014 at 03:22:21PM +0000, Will Newton wrote:
>>> On 16 January 2014 10:28, Will Newton <will.newton@linaro.org> wrote:
>>> > I'm not sure what the implications of this patch are, so I thought I would
>>> > post it here in the hope that someone can explain what might break.
>>
>> You're probably being a bit too honest here. :)
>>
>> The patch looks OK to me as far as it goes, but I count myself
>> unqualified to ack it.  I don't know enough about ARM to say whether
>> you've set pointer_equality_needed for all the relocs types you
>> should.  It needs to be set whenever you might be taking the address
>> of a function in non-PIC code or data.
>
> Thanks, I wasn't sure of the semantics of pointer_equality_needed.
> I'll investigate and post an updated patch.

After investigating the relocs involved I believe the original patch
is correct from that point of view. Richard, have you got any opinion
on the patch?

Thanks,


-- 
Will Newton
Toolchain Working Group, Linaro



More information about the Binutils mailing list