[PATCH] PR gas/16489: GAS doesn't complain about same register used for destination and index in AVX512 gather insn

H.J. Lu hjl.tools@gmail.com
Wed Jan 22 16:51:00 GMT 2014


On Wed, Jan 22, 2014 at 8:47 AM, Michael Zolotukhin
<michael.v.zolotukhin@gmail.com> wrote:
> Hi HJ,
>
> Thanks for the review, please find my answers below.
>
>> You removed assert on operands 0 and 2, added
>> check on operand 1.  Do your testcases cover
>> the removal of assert on operands 0 and 2?
>
> I didn't remove the assert on operands 0 and 2, I simply corrected it.
>  This assert is for AVX2 gathers, where we have mask, destination and
> index all in xmm/ymm registers.  Zmm isn't allowed there and was
> previously added to this assert by mistake.  This case has been
> covered by existing tests.

Please send a separate patch for assert removal along with
testsuite change which shows the impact of assert removal.

-- 
H.J.



More information about the Binutils mailing list