[PATCH] NDS32/opcodes: Fix out-of-range integer constant
Maciej W. Rozycki
macro@codesourcery.com
Fri Jan 10 20:32:00 GMT 2014
On Sat, 4 Jan 2014, Wei-cheng Wang wrote:
> Thanks for reviewing nds32 port :)
You're welcome, building with --enable-targets=all can often be helpful.
> According to the table of c99 6.4.4.1 Integer constants,
> the type of 0x100000000 is already long long int,
> so it shouldn't matter whether LL is suffixed.
Indeed, this has changed from C90 that 4.3.2 defaulted to (`-std=c99'
gets rid of the message even with 4.3.2). So far binutils have required
to support being built with a C90 compiler I believe. Of course since
you've been using int64_t you need a compiler that has a `long long' type
or an equivalent on 32-bit hosts anyway, so a plain C90 compiler won't do.
But making such a small correction to support older versions of GCC is
still worth the trouble IMHO.
Thanks to both of you for taking care of this.
Maciej
More information about the Binutils
mailing list