[PATCH/ARM][PING^2] Handle arbitrary .plt/.got displacements in ld on ARM
Yury Gribov
y.gribov@samsung.com
Mon Feb 24 15:09:00 GMT 2014
Link to original discussion:
https://sourceware.org/ml/binutils/2014-02/msg00053.html
Will Newton wrote:
>> I suggest to add an option --long-plt to allow generation of 4-word wide
>> .plt entries capable of handling arbitrary .plt/.got displacements:
>
> This sounds ok in principle to me (note I am not the ARM or a global
> maintainer).
> I think elf32_arm_use_long_plt_entry should probably be
> a boolean rather than size_t.
Done, thanks
> The comments on the PLT entries could be more verbose (i.e. point out
> that one PLT can address 28 bits and the other 32).
Ok, I tried my best.
> I wonder whether the FOUR_WORD_PLT #define is now rather ambiguous,
> maybe it should be removed?
That was my impression as well. At least there are no options in
configure scripts to define.
> The gold parts of this patch look like they are not related?
Sorry, unrelated indeed.
> And obviously there would need to be ld testcases.
Added ld/testsuite/ld-arm/long-plt-format.{s,d}. BTW are there any
guidelines for writing tests? I was unable to find any...
-Y
-------------- next part --------------
A non-text attachment was scrubbed...
Name: long_plt_2.diff
Type: text/x-diff
Size: 8173 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20140224/1c645e42/attachment.bin>
More information about the Binutils
mailing list