[commit] [patch] Fix PowerPC targets minor memory leaks found by Coverity

Jan Kratochvil jan.kratochvil@redhat.com
Tue Feb 4 19:19:00 GMT 2014


On Mon, 27 Jan 2014 01:12:15 +0100, Alan Modra wrote:
> On Fri, Jan 24, 2014 at 02:38:31PM +0100, Jan Kratochvil wrote:
> > 	* elf32-ppc.c (ppc_elf_relax_section): Free FIXUPS in error_return
> > 	return path.
> 
> This is not OK.  There are paths to error_return before fixups have
> been allocated and after fixups have been freed.  Please change the
> error_return free of fixups from a do { } while (); to a while () { }
> loop.  OK with that change.

I see you have checked it in in the meantime as a part of:
	commit 5446cbdf82892a800ed7eef563a795e75223ec52
	Author: Alan Modra <amodra@gmail.com>
	Date:   Thu Jan 30 08:26:02 2014 +1030
		ppc476 icache bug workaround


Checked in the other two parts as:
	2915c55b41d00f12ed6bc54b4160e3367065c1c8


Thanks,
Jan



More information about the Binutils mailing list