[PATCH] Fix PR ld/17277: bogus dynamic relocs and TEXTREL for ARM PC-relative relocs

Alan Modra amodra@gmail.com
Wed Aug 20 13:10:00 GMT 2014


On Tue, Aug 19, 2014 at 01:52:28PM -0700, Roland McGrath wrote:
> On Sun, Aug 17, 2014 at 4:30 PM, Alan Modra <amodra@gmail.com> wrote:
> > It seems to me the problem here is that may_become_dynamic_p should
> > not be set for pc_relative relocations against a local symbol.
> 
> Thanks for the pointer.  That makes lots of sense: the tests controlling
> that were the other places that had been explicitly checking for just
> R_ARM_REL32{,_NOI} and it seems right that all those tests should be
> consistent (now all changed to check howto->pc_relative).
> 
> I've extended my test case to cover the local-symbol case as well.  The new
> version of the change passes that new test and still has no regressions.
> Likewise for the 2.24 backport.
> 
> OK for trunk and 2.24 now?

Looks like a step in the right direction.  OK for trunk, and 2.24 in a
few days if there are no objections.

-- 
Alan Modra
Australia Development Lab, IBM



More information about the Binutils mailing list