[PATCH] Fix alignment for the first section frag on xtensa

Marc Gauthier marc@cadence.com
Tue Apr 22 01:40:00 GMT 2014


Sterling,

Sterling Augustine wrote:
> It seems likely to me that I could construct a case that made for a
> failure even after this patch is applied.
> 
> The real bug is in the linker relaxation mechanism for not honoring
> the section's alignment request. Linking should not change the
> alignment of the subsection, without regard to special Xtensa
> extensions--that violates Elf semantics.

FWIW, I believe David looked at doing a linker fix, but found it
more complicated than he liked, and preferred Max's simpler patch.

-Marc


> Nonetheless, as the fix is likely to modify the linker so that the
> alignment of the section is propagated to the first basic block,
> pre-empting that by having the assembler do it is probably OK. So I
> approve this patch.
> 
> Now would be a good time to get write-after-approval permission, so
> you can check this in yourself.



More information about the Binutils mailing list