[PATCH 1/2] pe/coff: Avoid a crash using objdump -p on the output of objcopy --only-keep-debug

Nicholas Clifton nickc@redhat.com
Tue Apr 8 10:04:00 GMT 2014


Hi Jon,

> I also posted a set of patches back in January [1].  I'd be grateful for any
> comments on those.
>
> [1] https://sourceware.org/ml/binutils/2014-01/msg00296.html


Oops - sorry - that one slipped through the net.

I reviewed and applied the patches.  They were OK although there were a 
few minor problems:

   * You did not update ld.textinfo's description of the --build-id 
linker command line option to mention the support for COFF format files.

   * There were quite a few places where the GNU Coding Standard was not 
being followed.  Especially the space between a function name and its 
opening parenthesis.  Ie "foo (bar)" not "foo(bar)".

   * Since this is a new feature it should also be mentioned in ld/NEWS.

I took care of all of these issues.

Cheers
   Nick




More information about the Binutils mailing list