[PATCH] gold: remove unused methods in Output_data_got_powerpc

Alan Modra amodra@gmail.com
Mon Oct 14 02:55:00 GMT 2013


On Sat, Oct 12, 2013 at 07:56:08AM -0700, Cary Coutant wrote:
> > Another option, avoiding the need for a virtual function and the
> > overhead this adds for all targets, is to override add_global(),
> > add_global_plt() etc. in Output_data_got_powerpc.  This keeps the
> > overhead to powerpc.cc.  Is this preferable?
> >
> > I also moved add_constant_pair into output.h for symmetry (and just in
> > case someone decided to optimise addition of constants).
> 
> This looks good to me. Thanks!

Now committed to mainline and 2.24 with this changelog.

	* output.h (Output_data_got::add_constant): Tidy.
	(Output_data_got::add_constant_pair): New function.
	* powerpc.cc (Output_data_got_powerpc): Override all Output_data_got
	methods used so as to first call reserve_ent().


-- 
Alan Modra
Australia Development Lab, IBM



More information about the Binutils mailing list