[PATCH] gold: remove unused methods in Output_data_got_powerpc
Alan Modra
amodra@gmail.com
Fri Oct 11 23:14:00 GMT 2013
On Sat, Oct 12, 2013 at 09:26:26AM +1030, Alan Modra wrote:
> On Fri, Oct 11, 2013 at 02:06:18PM -0700, Cary Coutant wrote:
> > > gold/
> > > * powerpc.cc (Output_data_got_powerpc): Remove unused methods
> > > add_got_entry and add_got_entry_pair.
> >
> > I'm not sure if this was work in progress or abandoned code that
> > didn't get cleaned up. Alan, please take a look.
>
> The latter. Roland, please apply.
No, wait a minute. I do want those functions, but probably
misunderstood C++ rules so they aren't effective. I need to somehow
arrange that Output_data_got_powerpc::reserve_ent() is called before
Output_data_got adds anything to its entries_ vector, because the
powerpc got header can sit somewhere in the middle of the GOT. What's
the best way to accomplish that?
--
Alan Modra
Australia Development Lab, IBM
More information about the Binutils
mailing list