[RFC][PATCH][ld][testsuite] Add -ffat-lto-objects option to some ld tests

[Kyrill Tkachov]

On 26/11/13 15:34, H.J. Lu wrote:
> On Tue, Nov 26, 2013 at 7:00 AM, Kyrill Tkachov <kyrylo.tkachov@arm.com> wrote:
>> On 26/11/13 14:58, H.J. Lu wrote:
>>> On Tue, Nov 26, 2013 at 6:55 AM, Kyrill Tkachov <kyrylo.tkachov@arm.com>
>>> wrote:
>>>> On 26/11/13 14:36, H.J. Lu wrote:
>>>>> On Tue, Nov 26, 2013 at 6:32 AM, Kyrill Tkachov <kyrylo.tkachov@arm.com>
>>>>> wrote:
>>>>>> Hi all,
>>>>>>
>>>>>> I'm seeing some ld testsuite failures on arm-none-linux-gnueabi and
>>>>>> aarch64-none-linux-gnu after a recent gcc commit (r205065) that set
>>>>>> -fno-fat-lto-objects as the default:
>>>>>>
>>>>>> PASS->FAIL: LTO 3 symbol
>>>>>> PASS->FAIL: PR ld/12758
>>>>>> PASS->FAIL: PR ld/12760
>>>>>> PASS->FAIL: PR ld/13183
>>>>>>
>>>>>> It seems that these tests need -ffat-lto-objects, at least on arm and
>>>>>> aarch64, but I'm not sure I understand the structure of these ld tests
>>>>>> well.
>>>>>>
>>>>>> Could someone please comment on whether this is the correct approach?
>>>>>> CC'ing H.J. since he wrote the lto.exp file.
>>>>>>
>>>>> Does -ffat-lto-objects always work when -flto is supported?
>>>>> If yes, OK for trunk.
>>>>
>>>> The gcc manual says about -ffat-lto-objects: " This option is effective
>>>> only
>>>> when compiling with -flto and is ignored at link time".
>>>> I'd think that it's supposed to always work with -flto.
>>>>
>>> Was -ffat-lto-objects added together with -flto?
>> Hmmm... it seems not. -ffat-lto-objects exists in 4.7 but not in 4.6. -flto
>> was added in 4.6.
>>
> Please add  -ffat-lto-objects to check_lto_available.
> Then you can use it in lto.exp.
Like this?

[ld/testsuite/]
2013-11-27  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>

     * ld-plugin/lto.exp: Add -ffat-lto-objects.
     * lib/ld-lib.exp (check_lto_available): Likewise.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ld-lto-fat.patch
Type: text/x-patch
Size: 1925 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20131128/9bad71f0/attachment.bin>