[PATCH] Add MIPS ufr macro instruction

[David Daney]

On 11/08/2013 06:03 AM, Andrew Bennett wrote:
> Hi,
>
> This patch adds the ufr macro instruction.  The instruction allows user mode to change the value of the FR mode bit.  I have added a macro into the gas MIPS backend that translates the ufr instruction to the appropriate ctc1 instruction.  The patch is attached, and the ChangeLog entry is below.
>

Can you explain why we need another magic code generation macro?

Why can't you just emit the real instructions to the .s file instead?


David Daney



> This is my first patch to binutils, so I am unsure the protocol on committing.  Would someone be able to clarify?
>
> Many thanks,
>
>
> Andrew
>
>
> 2013-11-08  Andrew Bennett  <andrew.bennett@imgtec.com>
> 	gas/config/
> 	* tc-mips.c (macro): Added support for ufr.
>
> 	gas/testsuite/gas/mips/
> 	* mips.exp: Added ufr test.
> 	* ufr.d: New.
> 	* ufr.s: New.
>
> 	include/opcode/
> 	* mips.h: Added M_UFR_I to the list of macros and updated the arg
> 	field character information for MIPS and microMIPS.
>
> 	opcodes/
> 	* micromips-opc.c (decode_micromips_operand): Added support for the ?
> 	character.
> 	(micromips_opcodes): Added the ufr macro instruction.
> 	* opcodes/mips-opc.c (decode_mips_operand): Added support for the ?
> 	character.
> 	(mips_builtin_opcodes): Added the ufr macro instruction.
>
>
> Andrew Bennett
> Software Design Engineer, MIPS Processor IP
> Imagination Technologies Limited
> t: +44 (0)113 2429814
> www.imgtec.com
>