Aw: Re: [PATCH] Support VU0 on MIPS R5900

[Richard Sandiford]

Hi Jürgen,

Thanks for the patch.  The code itself looks good.  However, I think it'd
be better to extend the test to include the four branch instructions.
It should also cover the LQC2 and SQC2 macros added here:

> @@ -8201,6 +8201,13 @@ macro (struct mips_cl_insn *ip)
>        /* Itbl support may require additional care here.  */
>        coproc = 1;
>        goto ld_st;
> +    case M_LQC2_AB:
> +      ab = 1;
> +      s = "lqc2";
> +      fmt = "E,o(b)";
> +      /* Itbl support may require additional care here.  */
> +      coproc = 1;
> +      goto ld_st;
>      case M_LDC3_AB:
>        ab = 1;
>        s = "ldc3";
> @@ -8390,6 +8397,13 @@ macro (struct mips_cl_insn *ip)
>        /* Itbl support may require additional care here.  */
>        coproc = 1;
>        goto ld_st;
> +    case M_SQC2_AB:
> +      ab = 1;
> +      s = "sqc2";
> +      fmt = "E,o(b)";
> +      /* Itbl support may require additional care here.  */
> +      coproc = 1;
> +      goto ld_st;
>      case M_SDC3_AB:
>        ab = 1;
>        gas_assert (!mips_opts.micromips);

E.g. it could check that things like:

	lqc2	$8, 0x8000($10)

get decomposed into the $1-based sequence.

Thanks,
Richard