[GOLD] PowerPC64 identical code folding

Ian Lance Taylor iant@google.com
Fri Mar 15 05:32:00 GMT 2013


On Thu, Mar 14, 2013 at 12:25 AM, Alan Modra <amodra@gmail.com> wrote:
> On Thu, Mar 14, 2013 at 05:22:15PM +1030, Alan Modra wrote:
>> On Tue, Mar 12, 2013 at 10:50:29AM +1030, Alan Modra wrote:
>> >     * gc.h (gc_process_relocs): Look through function descriptors
>> >     to determine shndx, symvalue and addend used by ICF.  Tidy
>> >     variable duplication.
>>
>> On testing this with more than the gold testsuite, I discovered that
>> --icf on PowerPC64 is quite broken.  We can't call function_location()
>> for a symbol defined in some object for which do_read_relocs() hasn't
>> been called;  The .opd info for that object isn't yet set up.
>>
>> It looks like I'll need to translate shndx, symvalue and addend in
>> icf.cc.
>
> Like this.  OK to apply?
>
>         * gc.h (gc_process_relocs): Don't look through function descriptors.
>         * icf.cc (get_section_contents): Do so here instead.

This is OK.

Thanks.

Ian



More information about the Binutils mailing list