[Gold] Question about the incorrect variable alignment if the alignment is greater than the page size

Alexander Ivchenko aivchenk@gmail.com
Thu Jun 6 05:46:00 GMT 2013


2013/6/6 Cary Coutant <ccoutant@google.com>:
> 2013-06-05  Alexander Ivchenko  <alexander.ivchenko@intel.com>
>
>         * layout.cc (Layout::set_segment_offsets): Taking care of the case when
>         the maximum segment alignment is larger than the page size.
>         * testsuite/Makefile.am (large_symbol_alignment): Test that Gold
>         correctly aligns the symbols with large alignemnt.
>         * testsuite/Makefile.in: Regenerate.
>         * testsuite/large_symbol_alignment.cc: New file.
>
> I've committed this patch on your behalf. Thanks for working on it!

Thanks! But it seems that you forgot to add the file
large_symbol_alignment.cc from the patch.. (I have it in the patch
that I attached above)
In make check-gold it lead to:

make[4]: *** No rule to make target `large_symbol_alignment.cc',
needed by `large_symbol_alignment.o'.  Stop.
make[4]: Leaving directory `.../src/binutils_obj/gold/testsuite'

thanks,
Alexander



More information about the Binutils mailing list