[PATCH] ld: add support for LOG2() in linker scripts

nick clifton nickc@redhat.com
Fri Jul 19 13:30:00 GMT 2013


Hi Clemens,
> Please find attached a patch against the GNU ld source to add a unary
> LOG2() function, returning the binary logarithm of its argument, rounded
> towards 0. The implementation also returns 0 for a zero argument.

Thanks for creating this patch.


> A couple questions:
>   - Would somebody please merge this?

Not right away - there are still a few problems to address.  See below.


>   - Where can I find the source for [2], so I can add documentation?

In <binutils_sources>/ld/ld.texinfo


>   - Do you require some form of copyright assignment?

Yes - an FSF copyright assignment.  I have attached the form that you 
can fill in and email off in order to start this process rolling.


 > Are there other formal requirements for this patch to be applied?

Formal no, but there are a couple of things missing:

   1. A ChangeLog entry describing the patch.

   2. A patch to the ld/NEWS file mentioning the new feature.

   3. A testcase in the ld/testsuite/ld-scripts directory to make sure 
that the new directive works correctly and continues to work in the future.

Cheers
   Nick

-------------- next part --------------
Please email the following information to assign@gnu.org, and we
will send you the assignment form for your past and future changes.

Please use your full legal name (in ASCII characters) as the subject
line of the message.
----------------------------------------------------------------------
REQUEST: SEND FORM FOR PAST AND FUTURE CHANGES

[What is the name of the program or package you're contributing to?]


[Did you copy any files or text written by someone else in these changes?
Even if that material is free software, we need to know about it.]


[Do you have an employer who might have a basis to claim to own
your changes?  Do you attend a school which might make such a claim?]


[For the copyright registration, what country are you a citizen of?]


[What year were you born?]


[Please write your email address here.]


[Please write your postal address here.]





[Which files have you changed so far, and which new files have you written
so far?]


More information about the Binutils mailing list