[PATCH 1/5] New target port: Andes 'nds32'. (bfd)

Kuan-Lin Chen kuanlinchentw@gmail.com
Fri Jul 12 03:00:00 GMT 2013


Hi, Joseph

I've fix the first patch according to your suggestions.
Attached please find the revised version.

1. Licence notices is changed to GPLv3.
2. FSF postal address is modified to be right.
3. Add static/const  for array/variables if possible.
4. Remove all global variables and pass these target options by the structure.
5. Remove the comment "FIXME: This should not be a static variable.", because
this variable should be static. It is a wrong comment.

BTW, nds32_insertion_sort uses alloca for constant size Elf_Internal_Rela,
and only once in each function call.  Therefore, I think this is safe to use
alloca here.  If I am wrong, please feel free to correct me. Thanks.

Thank you again for your time to review.

-- 
Best regards,
Kuan-Lin Chen.
kuanlinchentw@gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: binutils-1-bfd.patch.tar.bz2
Type: application/x-bzip2
Size: 69236 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20130712/a748ce8a/attachment.bz2>


More information about the Binutils mailing list