[PATCH 4/5] New target port: Andes 'nds32'. (ld)

Joseph S. Myers joseph@codesourcery.com
Tue Jul 9 16:51:00 GMT 2013


As with the assembler patch, this patch is missing documentation; you have 
architecture-specific linker options, so need to document them in 
ld.texinfo.

> 	* scripttempl/nds32elf.sc}: New file for nds32 support.

Please don't add new variant copies of elf.sc like this.  By forking 
elf.sc you are, as just one example, missing DWARF 3 sections that elf.sc 
gets from DWARF.sc.  Of course that individual issue could be fixed by 
using DWARF.sc from this script, but instead it's better to make elf.sc 
handle more variables as needed so it can do what you need for your port.  
If it really isn't possible to use elf.sc, you need to explain why, and 
justify every difference between elf.sc and your script as being actually 
necessary for your port rather than just resulting from having forked an 
old version of elf.sc and not merged in more recent elf.sc changes since 
then.

-- 
Joseph S. Myers
joseph@codesourcery.com



More information about the Binutils mailing list