[PATCH] gas: arm: include location in "bad immediate value for 8-bit offset" error

Roland McGrath mcgrathr@google.com
Mon Jan 28 23:52:00 GMT 2013


For no apparent reason this one (fix-time) error fails to include source
line information.  That's not right.

Ok for trunk and 2.23?

Thanks,
Roland


gas/
2013-01-28  Roland McGrath  <mcgrathr@google.com>

	* config/tc-arm.c (md_apply_fix): Use as_bad_where for "bad
	immediate value for 8-bit offset" error so it shows line info.

--- a/gas/config/tc-arm.c
+++ b/gas/config/tc-arm.c
@@ -21549,8 +21549,9 @@ md_apply_fix (fixS *	fixP,
 	    as_bad_where (fixP->fx_file, fixP->fx_line,
 			  _("invalid literal constant: pool needs to be closer"));
 	  else
-	    as_bad (_("bad immediate value for 8-bit offset (%ld)"),
-		    (long) value);
+	    as_bad_where (fixP->fx_file, fixP->fx_line,
+			  _("bad immediate value for 8-bit offset (%ld)"),
+			  (long) value);
 	  break;
 	}



More information about the Binutils mailing list